refactor(layout): move change detection into resolved layout stage#2814
Open
tupizz wants to merge 1 commit intotadeu/sd-2563-04-border-datafrom
Open
refactor(layout): move change detection into resolved layout stage#2814tupizz wants to merge 1 commit intotadeu/sd-2563-04-border-datafrom
tupizz wants to merge 1 commit intotadeu/sd-2563-04-border-datafrom
Conversation
superdoc-bot
bot
added
review: thorough
review: careful
and removed
review: thorough
labels
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versionfield to all resolved item typesversionSignature.tsandhashUtils.tsin layout-resolved (moved from painter)deriveBlockVersion()andfragmentSignature()now compute during resolutionversionfor change detection with legacy fallbackAfter this PR,
ResolvedLayoutcarries ALL data the painter needs. The legacysourceLayout,blocks, andmeasuresfields inDomPainterInputcan be removed in a follow-up.PR Stack (SD-2563: Dumb Painter Refactor)
Test plan